search

nativescript-community / perms

An unified permissions API for NativeScript on iOS and Android.
https://nativescript-community.github.io/perms/
Apache License 2.0
12 stars 9 forks source link

feat(ios): add ios12 notification providesAppNotificationSettings #8

Closed francois-pasquier closed 3 years ago

francois-pasquier commented 3 years ago

Closes https://github.com/nativescript-community/perms/issues/7

farfromrefug commented 3 years ago

@francois-pasquier merci bcp pour ta PR! je te fais une release au plus vite! (tu es bien Francais il me semble ;))

francois-pasquier commented 3 years ago

@francois-pasquier merci bcp pour ta PR! je te fais une release au plus vite! (tu es bien Francais il me semble ;))

Top, merci beaucoup : )

farfromrefug commented 3 years ago

@francois-pasquier did you test it ? UIUserNotificationType.ProvidesAppNotificationSettings does not seem to exist. should'nt we use UNNotificationSettings.providesAppNotificationSettings? Actually seems like it could be UNAuthorizationOptions.ProvidesAppNotificationSettings

francois-pasquier commented 3 years ago

ahhhh, I'm so sorry, it's my first time on using native API on nativescript... Do you want me to provide an other PR?

farfromrefug commented 3 years ago

@francois-pasquier no i ll fix it. Looking at https://github.com/mrousavy/react-native-notification-badge now to see how they do it

francois-pasquier commented 3 years ago

Sorry for the trouble!

farfromrefug commented 3 years ago

@francois-pasquier could you try this and report if it works on iOS >= 12 ? nativescript-community-perms-2.1.8.zip