search

nativescript-community / solid-js

SolidJS for NativeScript
MIT License
56 stars 1 forks source link

Typescript: rows/columns attribute missing from <gridlayout> #8

Closed timbasel closed 1 month ago

timbasel commented 11 months ago

The rows and column attributes (and maybe more) is missing from the type of the element.

export const App = () => {
  return (
    <gridlayout rows="*,50">
      ...
    </gridlayout>
  )
}
ERROR in ./app/app.tsx
TS2322: Type '{ children: Element[]; rows: string; }' is not assignable to type 'JSXElementAttributes<"GridLayout">'.
Property 'rows' does not exist on type 'JSXElementAttributes<"GridLayout">'. Did you mean 'row'?

Functionally everything works, only the typings are incomplete.

ammarahm-ed commented 1 month ago

This has been fixed in the latest typings.