search

nativescript-community / texttospeech

Text to Speech NativeScript plugin for Android & iOS :loudspeaker:
http://nativescript-community.github.io/texttospeech/
MIT License
50 stars 24 forks source link

Added callback for speech finish and new pause and resume methods #4

Closed stefalda closed 7 years ago

stefalda commented 8 years ago

Hi, I've implemented both for iOS and for Android the delegation pattern to be able to be notified when the speech has finished. I've also added two method to pause and resume speech, and updated the documentation.

Give it a try and if you see no issue you can merge the changes.

Stefano

bradmartin commented 8 years ago

@stefalda - I'll refactor this into the typescript files and get it published asap. Nice work 👍

bradmartin commented 8 years ago

I did a lot of refactoring to TS, used your code for the methods you added and the finished event. Android is working great, could you review the pause/resume for iOS and then possibly rebase and PR the fix. I don't think it's working, but didn't test thoroughly. Thanks!

stefalda commented 8 years ago

Hi @bradmartin, sorry for the delay... I'll try to rebase asap...

bradmartin commented 8 years ago

I think I left off and only the iOS pieces needed a little touching up. Android seemed to work great. It's likely a variable out of place or something I overlooked. I rewrote it pretty quick so might have just missed something :) thanks. If you don't have time I'll circle back to it eventually. No issues filled on it yet which is good.

On Fri, Oct 7, 2016, 5:22 AM Stefano Falda notifications@github.com wrote:

Hi @bradmartin https://github.com/bradmartin, sorry for the delay... I'll try to rebase asap...

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bradmartin/nativescript-texttospeech/pull/4#issuecomment-252208727, or mute the thread https://github.com/notifications/unsubscribe-auth/AFulhBVPZlfTx9O8HwrVuCRk7W6EeSgTks5qxh1xgaJpZM4J6Bo_ .