nativescript-community / ui-cameraview

Apache License 2.0
6 stars 1 forks source link

appPackageJson.dependencies mistaken for dependencies {} block #1

Open wa3l opened 10 months ago

wa3l commented 10 months ago

Hi, I had a build issue due to Gradle mistaking this line for a dependencies {} block when it generates build.gradle. Removing the line in node_modules/@nativescript-community/ui-cameraview/platforms/android/include.gradle (not commenting it out) fixed the issue. Seems that gradle treats the word dependencies like a reserved word.

Credit goes to @CatchABus for catching it.

CatchABus commented 10 months ago

Let me point out this is the fault of NativeScript CLI being unable to parse those blocks properly. The problem seems to lie in this method: https://github.com/NativeScript/nativescript-cli/blob/main/lib/services/android-plugin-build-service.ts#L179

farfromrefug commented 10 months ago

OK it is weird it works here. Must be my CLI fork which makes it work Will have to find what I changed... Just so you know those line exist to make the plugin build using my fork of N if it is installed