search

nativescript-community / ui-canvas

Implement Canvas into your NativeScript apps.
https://nativescript-community.github.io/ui-canvas/
Apache License 2.0
31 stars 9 forks source link

chore: Make `_drawPath` accept a path of type `Path`. #38

Closed CatchABus closed 2 years ago

CatchABus commented 2 years ago

I thought it would be less confusing if one always gave a path parameter of type Path in iOS _drawPath method. This is more like a suggestion. What do you think?

farfromrefug commented 2 years ago

@DimitrisRK it is a private method and in fact i would prefer it supports them all. Not sure if still use it with path as a native path but i know i did and i think we still could

CatchABus commented 2 years ago

@DimitrisRK it is a private method and in fact i would prefer it supports them all. Not sure if still use it with path as a native path but i know i did and i think we still could

I see your point. Thanks for the clarification.