search

nativescript-community / ui-canvas

Implement Canvas into your NativeScript apps.
https://nativescript-community.github.io/ui-canvas/
Apache License 2.0
31 stars 9 forks source link

Update to NS 8.4 #41

Closed kefahB closed 1 year ago

kefahB commented 1 year ago

Hi @farfromrefug ,

layout isn't part from @nativescript/core/utils/utils any more, it can be imported from @nativescript/core/utils/layout-helper but this is not backward compatible with NS 8.3 I think !

MrSnoozles commented 1 year ago

~@kefahB How about instead of relying on another file path to change it to an import from core directly? That should be compatible with NS 7.x and above~

EDIT: That does not work

farfromrefug commented 1 year ago

@MrSnoozles did not even know that syntax was possible. For now i ll accept @kefahB merge to quickly fix as i need to update a ton of plugins

kefahB commented 1 year ago

@farfromrefug I'll update ui-label as well and let yo know

MrSnoozles commented 1 year ago

@kefahB @farfromrefug You didn't know that syntax was possible, because it is not. It works for object destructuring, but not in imports. Sorry for the confusion.

farfromrefug commented 1 year ago

@MrSnoozles oh damn i am too tired :D