search

nativescript-community / ui-canvas

Implement Canvas into your NativeScript apps.
https://nativescript-community.github.io/ui-canvas/
Apache License 2.0
31 stars 9 forks source link

fix(ui-canvas): Android bitmap pixels missing scale #59

Closed CatchABus closed 1 month ago

CatchABus commented 1 month ago

It seems android Bitmap is missing pixel scaling as it parses width and height as raw pixels.

farfromrefug commented 1 month ago

@CatchABus Not sure about that. If you create an Canvas(500,500), you expect the image to be exactly 500x500. With your change it is not

CatchABus commented 1 month ago

@CatchABus Not sure about that. If you create an Canvas(500,500), you expect the image to be exactly 500x500. With your change it is not

I see your point here. In my case, I used it for offscreen canvas support where I used dip dimensions as parameters on Canvas constructor. I can scale them on my side, but is this consistent with iOS though?

farfromrefug commented 1 month ago

@CatchABus yes i think it is. That s the way i use it in my apps

CatchABus commented 1 month ago

I see, thanks for clarifying. :smile: