feat: add highlight row events and improved stability

nativescript-community / ui-collectionview

Allows you to easily add a collection view (grid list view) to your projects. Supports vertical and horizontal modes, templating, and more.

Apache License 2.0

59 stars 18 forks source link

feat: add highlight row events and improved stability #48

Open NathanWalker opened 1 year ago

NathanWalker commented 1 year ago

added itemHighlight and itemHighlightEnd events
enabled displayItem event for custom show animation handling
improved strong type checking and reduced scoped variable usage
strengthen async conditions of null/undefined
uses deref for iOS weakref since supported there, keep get on android for now

MrSnoozles commented 1 year ago

@farfromrefug Is it possible to merge the changes? I implemented the CollectionView on Android. Upon testing on iOS I have regular app crashes that are related to the CollectionView. Would like to see if this PR solves them.

farfromrefug commented 1 year ago

@MrSnoozles that PR will propably not solve it. And you should report with crash callstack son that we can fiest mâle sur it actually is an issue with collectionview