search

nativescript-community / ui-collectionview

Allows you to easily add a collection view (grid list view) to your projects. Supports vertical and horizontal modes, templating, and more.
Apache License 2.0
59 stars 18 forks source link

fix(vue): destroy componentInstance and not the parent component #50

Closed rigor789 closed 1 year ago

rigor789 commented 1 year ago

context points to the parent component, so in some cases this would destroy a parent component instance, causing reactivity and interaction to stop working.

Changing it to componentInstance should now correctly destroy the component instance for the cell rather than any parent.

https://github.com/vuejs/vue/blob/8d3fce029f20a73d5d0b1ff10cbf6fa73c989e62/src/core/vdom/vnode.js#L13

farfromrefug commented 1 year ago

Nice one @rigor789 sorry about that :p