search

nativescript-community / ui-collectionview

Allows you to easily add a collection view (grid list view) to your projects. Supports vertical and horizontal modes, templating, and more.
Apache License 2.0
59 stars 18 forks source link

scroll to offsets values. dy and dx required for Android. #63

Closed SeanKelly369 closed 1 year ago

SeanKelly369 commented 1 year ago

Allows scrolling offset of CollectionViews to be handler and updated outside of the CollectionView. For example, syncing the positions of multiple CollectionViews.

farfromrefug commented 1 year ago

@SeanKelly369 wouldn't it be better to have one method with both DX and dy? That way you could handle all cases

SeanKelly369 commented 1 year ago

@farfromrefug Sure, that can be done if you want.

farfromrefug commented 1 year ago

@SeanKelly369 think it would be best if you could update the PR

SeanKelly369 commented 1 year ago

I was thinking about this further. ScrollView has these same functions. Keeping the same names would make it easier for developers to change types. With this in mind, wouldn't it make seen to have 3 functions in total?

farfromrefug commented 1 year ago

@SeanKelly369 good question. Honestly i would prefer collectionview to remain as fast and small as possible. we could pave the way for scrollview to follow in the future

SeanKelly369 commented 1 year ago

Updated, but can it be tested before committing?