nativescript-community / ui-drawer

NativeScript plugin that allows you to easily add a side drawer (side menu) to your projects.
https://nativescript-community.github.io/ui-drawer/
Apache License 2.0
24 stars 12 forks source link

Scrolling, ListView, CollectionView all get cut off on Android #29

Open bradrice opened 6 months ago

bradrice commented 6 months ago

I the content is scrolling and it goes out of the drawer it does not scroll on Android.

Everything works perfectly on iOS. I'm trying to get scrolling lists working in a drawer for Android.

farfromrefug commented 6 months ago

@bradrice did you try with NestedScrollView ? BTW CollectionView is working fine here. I use it in all my apps

bradrice commented 6 months ago

I can't seem to figure out how to use NestedScrollView in angular. However, I don't really have nested scrollviews, they are independent in drawer windows where they don't work.

Here is what I get:

Here is ios https://drive.google.com/file/d/1ZXwrFjVOim5w-di1IcWHPzGvzywW1oNV/view?usp=drive_link Here is Android: https://drive.google.com/file/d/1pn6sxyPDwFBL7GD8XA85PVXxCdGkaOnF/view?usp=drive_link I don't really have nested scrollviews they are independent and in the community drawer

farfromrefug commented 6 months ago

nested term iOS used based on the android native class name. and I am. almost certain you need it ! again I know there was an angular example on discord

bradrice commented 6 months ago

@bradrice did you try with NestedScrollView ? BTW CollectionView is working fine here. I use it in all my apps

Are your collectionviews going out of the bounds of the drawer so you have to scroll to get to the bottom?

farfromrefug commented 6 months ago

yes they do

ignacio68 commented 6 months ago

I can't do scroll in Android, too. In iOS works fine

farfromrefug commented 6 months ago

@bradrice @bradrice indeed by default the drawer gesture will interfeer with a listview. to fix this you need to add gesture settings like this https://github.com/Akylas/oss-weather/blob/master/app%2Fcomponents%2FCompareWeatherSingle.svelte#L292 I will think about making this the default. you might not need the minDist setting

ignacio68 commented 6 months ago

@farfromrefug In my application works better with these parameters:

:gestureHandlerOptions="{ failOffsetYStart: -10, failOffsetYEnd: 10, }"

bradrice commented 5 months ago

I'm still not able to use a Scrollview in the drawer with gestureHandlerOptions

farfromrefug commented 5 months ago

@bradrice then share a simple reproducible example (not angular please) to show what you are trying to do and whats not working

bradrice commented 5 months ago

That’s right I forgot you were non-angular. I am just switching back to radsidebar.

Brad Rice @.***

On Wed, Mar 27, 2024 at 12:45 PM farfromrefuge @.***> wrote:

@bradrice https://github.com/bradrice then share a simple reproducible example (not angular please) to show what you are trying to do and whats not working

— Reply to this email directly, view it on GitHub https://github.com/nativescript-community/ui-drawer/issues/29#issuecomment-2023271880, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACCPYEFO6WM3MIJCY4ETPTY2LSSFAVCNFSM6AAAAABEGDMEJWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRTGI3TCOBYGA . You are receiving this because you were mentioned.Message ID: @.***>

farfromrefug commented 5 months ago

@bradrice sorry to hear that. non-angular is also because I know the core component to work and reproducing it without angular tells me there is a real issue with the plugin and not only with the angular wrapper

bradrice commented 5 months ago

Ok, thanks for the clarification. I’ll try to spin up a core app with your plugin, but I’m trying to get my app out the door.

On Wed, Mar 27, 2024 at 12:56 PM farfromrefuge @.***> wrote:

@bradrice https://github.com/bradrice sorry to hear that. non-angular is also because I know the core component to work and reproducing it without angular tells me there is a real issue with the plugin and not only with the angular wrapper

— Reply to this email directly, view it on GitHub https://github.com/nativescript-community/ui-drawer/issues/29#issuecomment-2023309336, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACCPYEEKHWS33YNI2FQ6CTY2L23RAVCNFSM6AAAAABEGDMEJWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRTGMYDSMZTGY . You are receiving this because you were mentioned.Message ID: @.***>

farfromrefug commented 5 months ago

@bradrice no worries if you can in the future it would be great yes (vue works too as no wrapper is needed). But finish your app first!

bradrice commented 5 months ago

Will do, thanks! I wonder if it has something to do with having multiple drawers on my page. I'm converting them to modals, so I don't have to use multiple.

On Wed, Mar 27, 2024 at 3:55 PM farfromrefuge @.***> wrote:

@bradrice https://github.com/bradrice no worries if you can in the future it would be great yes (vue works too as no wrapper is needed). But finish your app first!

— Reply to this email directly, view it on GitHub https://github.com/nativescript-community/ui-drawer/issues/29#issuecomment-2023849110, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACCPYD2LOYCCRXX333JMLLY2MIZDAVCNFSM6AAAAABEGDMEJWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRTHA2DSMJRGA . You are receiving this because you were mentioned.Message ID: @.***>

-- Brad Rice @.***

farfromrefug commented 5 months ago

@bradrice possible. Multiple is not the most common use case. But it should work!