Update to not use deprecated API

nativescript-community / ui-image

Advanced and efficient image display plugin which uses Fresco (Android) and SDWebImage (iOS) to implement caching, placeholders, image effects, and much more.

Apache License 2.0

36 stars 9 forks source link

Update to not use deprecated API #20

Closed shiv19 closed 8 months ago

shiv19 commented 4 years ago

The following APIs are deprecated in {N} 6.2

fromFile() is deprecated. Use ImageSource.fromFile[Sync]() instead.
fromResource() is deprecated. Use ImageSource.fromResource[Sync]() instead.

Doing this would be a breaking change for this plugin

farfromrefug commented 4 years ago

@shiv19 indeed i want to do this but it will mean losing support for <6.2 But anyway i am going to migrate it to @nativescript so i will lose support for <6.2 and tns-core-modules anyway...

farfromrefug commented 4 years ago

@shiv19 just published a beta version 3.0.0 with the fix + migration to @nativescript. I you could test it that would be awesome!