search

nativescript-community / ui-image

Advanced and efficient image display plugin which uses Fresco (Android) and SDWebImage (iOS) to implement caching, placeholders, image effects, and much more.
Apache License 2.0
36 stars 9 forks source link

Crashing on iOS when scrolling #34

Closed keerl closed 3 years ago

keerl commented 3 years ago

Found a problem today in my app. I use ui-image in a grid scroll view and when I scroll down the list the app will sometimes crashes violently. There is no error shown in the console, and the only way I can get an error is by going into the logs (see attached image).

Demo project is attached.

ui-image-crash.zip

Screen Shot 2020-11-09 at 2 09 59 PM

ezgif com-gif-maker

keerl commented 3 years ago

Oops, it looks like this could be the same issue as https://github.com/nativescript-community/ui-image/issues/32 ? Was never solved though?

farfromrefug commented 3 years ago

Using the v8 runtime? Can you try without it?

keerl commented 3 years ago

That seems to be the problem. Was using v8 when it was crashing. Switched to "tns-ios": "6.5.3" and the problem is gone. Any idea how to fix it w/ v8? Should I report it over there?

captainhaddockfr35 commented 3 years ago

Same problem here with ns7 / v8

farfromrefug commented 3 years ago

@pboulch @keerl did not really have the time to look at it. But it would be good to report on the v8 runtime repo. THey might have an idea

keerl commented 3 years ago

I did report it there https://github.com/NativeScript/ns-v8ios-runtime/issues/81 it may helpful for @pboulch to post on that issue as well.

Jaroslav84 commented 3 years ago

same issue here when scrolling table of images. ns7 / v8

Seems like the crash in iOS pod sdwebimage @ this function:

farfromrefug commented 3 years ago

@Jaroslav84 @keerl @pboulch please can you try 4.0.14?

Jaroslav84 commented 3 years ago

@farfromrefug same crash spot with 4.0.14.

I'm loading 50 images into a tableList (Angular) with small thumbnail png's. After scrolling (on device) it crashes the same way.

romandrahan commented 3 years ago

@farfromrefug, still crashing for me as well with the 4.0.14.

romandrahan commented 3 years ago

Works fine with @nativescript/ios@7.0.6.

georgemark0v commented 3 years ago

still crash "@nativescript/ios": "^7.0.6 "@nativescript-community/ui-image": "^4.0.14"

farfromrefug commented 3 years ago

@georgemark0v try to remove platforms/node_modules/hooks and build again

keerl commented 3 years ago

Also confirming this fixed the issue. Good to close.

georgemark0v commented 3 years ago

@georgemark0v try to remove platforms/node_modules/hooks and build again

Solved. Thanks.