nativescript-community / ui-image

Advanced and efficient image display plugin which uses Fresco (Android) and SDWebImage (iOS) to implement caching, placeholders, image effects, and much more.
Apache License 2.0
36 stars 9 forks source link

Stretch setting not working with ImageSource as src #37

Closed tomups closed 3 years ago

tomups commented 3 years ago

Which platform(s) does your issue occur on?

Please, provide the following version numbers that your issue occurs with:

Please, tell us how to recreate the issue in as much detail as possible.

If you assign a ImageSource as src instead of a string path, the stretch setting seems to have no effect. Example with both images using stretch="aspectFill".

image

Is there any code involved?

Here is a zip with a basic Angular project showing the issue: MyApp.zip

farfromrefug commented 3 years ago

@tomtastico thanks i can confirm the issue. Sadly i have no fix for now. I am on the lookout for a solution!

tomups commented 3 years ago

@farfromrefug I have submitted a possible fix here https://github.com/nativescript-community/ui-image/pull/38

tomups commented 3 years ago

The bug is not present in iOS

IMG_0024

farfromrefug commented 3 years ago

@tomtastico your issue should now be fixed the right way in the newly published version

tomups commented 3 years ago

That's great, thanks! I was sure there was a better way :)