search

nativescript-community / ui-image

Advanced and efficient image display plugin which uses Fresco (Android) and SDWebImage (iOS) to implement caching, placeholders, image effects, and much more.
Apache License 2.0
36 stars 9 forks source link

Update quotes from double to single #4

Closed DimitarTodorov closed 5 years ago

farfromrefug commented 5 years ago

@DimitarTodorov that's not the solution. I actually don't want to commit those files are they are generated. Thought they were already ignored... The issue is that tsc generate files with double quote instead of single quote. So tslint is not happy

DimitarTodorov commented 5 years ago

Hi @farfromrefug It seems that in the current configuration the tsc compiler generates enums with double quoted string values. The solution that can be made here is to exclude the .d.ts files from the ci.tslint check, since they are generated from already checked .ts files. "ci.tslint": "npm i && tslint '**/*.ts' --config './tslint.json' --exclude '**/node_modules/**' --exclude '**/platforms/**' --exclude '**/*.d.ts'",

farfromrefug commented 5 years ago

@DimitarTodorov that seems like the perfect approch to me. Just pushed the change. Will wait to see if it works. Thanks!