Closed VladimirAmiorkov closed 4 years ago
@VladimirAmiorkov Sorry i actually copied the one from nativescript-fresco
but did not updated it enough.
Just for the context i don't use the same directory structure as others nativescript plugins because it creates a lot of issues. Especially :
npm link
or use file:/../src
you end up with a webpack installation which does not know what file to use. Already took me days to find bugs because of that.src
folder contains a package.json which has dev dependencies which can create bad consequences when used with npm link
or file:/../src
Now all that being said it has a few issues that i still need to handle:
tsc
does not copy existing typings, thus the use of cpy
plugin
should be synced (without dev-deps) with the one from topplugin
to get the readme on npmWill fix all now
@VladimirAmiorkov changed the doc a bit. Can you look and tell me if it's ok with you?
@farfromrefug Yes now it is better. One thing that I personally find useful to have in a "Developer workflow" is also explain the steps required to manually build the plugins code so that it is ready for use (with symlink or npm link). Basically the above notes you have already mentioned I think that they are useful to have in a section in the DeveloperWorkflow.md so that anyone new to the repository can get the idea behind the current build process of the plugin's code. Feel free to close this issue.
The workflow described here for contributions to this repository is missing many of the details it should contain like:
Also it contains outdated command
npm run demo.ng.android
that is not found in the package.json located at thesrc
directory.