nativescript-community / ui-image

Advanced and efficient image display plugin which uses Fresco (Android) and SDWebImage (iOS) to implement caching, placeholders, image effects, and much more.
Apache License 2.0
36 stars 9 forks source link

DevelopmentWorkflow is missing a lot of information and is not helpful. #6

Closed VladimirAmiorkov closed 4 years ago

VladimirAmiorkov commented 5 years ago

The workflow described here for contributions to this repository is missing many of the details it should contain like:

Also it contains outdated command npm run demo.ng.android that is not found in the package.json located at the src directory.

farfromrefug commented 5 years ago

@VladimirAmiorkov Sorry i actually copied the one from nativescript-fresco but did not updated it enough. Just for the context i don't use the same directory structure as others nativescript plugins because it creates a lot of issues. Especially :

Now all that being said it has a few issues that i still need to handle:

Will fix all now

farfromrefug commented 5 years ago

@VladimirAmiorkov changed the doc a bit. Can you look and tell me if it's ok with you?

VladimirAmiorkov commented 5 years ago

@farfromrefug Yes now it is better. One thing that I personally find useful to have in a "Developer workflow" is also explain the steps required to manually build the plugins code so that it is ready for use (with symlink or npm link). Basically the above notes you have already mentioned I think that they are useful to have in a section in the DeveloperWorkflow.md so that anyone new to the repository can get the idea behind the current build process of the plugin's code. Feel free to close this issue.