search

nativescript-community / ui-image

Advanced and efficient image display plugin which uses Fresco (Android) and SDWebImage (iOS) to implement caching, placeholders, image effects, and much more.
Apache License 2.0
36 stars 9 forks source link

Feature: Prefetching #8

Closed ddfreiling closed 5 years ago

ddfreiling commented 5 years ago

Implemented these pipeline methods:

farfromrefug commented 5 years ago

@ddfreiling amazing thanks a lot! Did you test it well? Don't really have time to test. Can i release? ;)

ddfreiling commented 5 years ago

No problem @farfromrefug. Tested it a lot with the angular demo, and it seems to work well and handle errors correctly. I would definitely prefer you do some cursory testing before releasing it.

The only thing which bugs me, is that Fresco's prefetchToBitmapCache also seems to store in the disk cache, while it does not on iOS.

This could be "smoothed out" by having iOS store to both caches too. Alternatively we could just add a new prefetchToCaches, so that prefetching to all 3 cache types are possible.

ddfreiling commented 5 years ago

@farfromrefug Any plan for when you'll release this?

farfromrefug commented 5 years ago

@ddfreiling may be next week if that s ok. Need to test it but dont really have time right now. Big release time for an app ;)

ddfreiling commented 5 years ago

@farfromrefug that's perfectly fine, good luck with the big release :)