search

nativescript-community / ui-label

Alternative to the built-in NativeScript Label but with better performance and additional features such as HTML rendering and more.
Apache License 2.0
19 stars 7 forks source link

enableIOSDTCoreText is not a function #19

Open fpaaske opened 1 year ago

fpaaske commented 1 year ago

I'd just let you know that we ran into this issue recently. After some debugging it seems like it's probably due to this commit from https://github.com/nativescript-community/text

This bug came to us via a patch release of ui-label, but I think this qualifies as a breaking change (in the text-repo)? That would prevent it from sneaking in unnoticed, I think 😊

Anyway, I see that the feature was removed, so we've adapted the code. Perhaps you could update the documentation?

Thanks for an otherwise excellent plugin! ❤️

farfromrefug commented 1 year ago

@fpaaske sorry about this. I can bring in back if you want but dtcoretext hasn't been updated in a very long time. otherwise I LL update the doc. thanks

fpaaske commented 1 year ago

No worries, and thanks for the quick response! I don't think we need DTCoreText. I don't even know what it's for, except is was recommend for performance some years back.

The plugin seems to work the same without it 👍

farfromrefug commented 1 year ago

ok so you understand dtcoretext was there to parse XML string into NSattributedstring. but now in latest iOS versions iOS do it pretty well. in the beginning dtcoretext was faster but it is not maintained anymore and I dont even think it is faster now. will update the doc

fpaaske commented 1 year ago

That's good to know. I guess the fewer deps the better. Thanks again!