code update - Githubissues

nativescript-community / ui-lottie

NativeScript plugin to expose Airbnb Lottie

https://github.com/airbnb/lottie-android

Other

177 stars 57 forks source link

code update #54

Closed farfromrefug closed 2 years ago

farfromrefug commented 4 years ago

Hey Brad,

I migrated your project to the latest version of lottie. Had to modify the swift code a bit. Now i did that as a fork because i wanted to change the plugin structure like i always do with my plugins. https://github.com/farfromrefug/nativescript-lottie

let me know if you want a PR

bradmartin commented 4 years ago

If all functionality still works or if it's minor changes to be on latest Lottie then definitely 💯👍🔥

farfromrefug commented 4 years ago

@bradmartin well feature wise it is more than minor:

updated to latest api
added support for json string in src
support for src from assets folder
bug fixes and corrections
complete new repo structure with lerna integration

bradmartin commented 4 years ago

all that sounds good to me, IDK much about lerna but assuming the hooks still work for pre-commit stuff then all good to me if you wanna PR it

adeyemiadetayoccl commented 4 years ago

how is this going

farfromrefug commented 4 years ago

@adeyemiadetayoccl https://github.com/bradmartin/nativescript-lottie/pull/62