nativescript-community / ui-lottie

NativeScript plugin to expose Airbnb Lottie
https://github.com/airbnb/lottie-android
Other
177 stars 57 forks source link

code update #54 #62

Closed farfromrefug closed 4 years ago

farfromrefug commented 4 years ago
farfromrefug commented 4 years ago

@bradmartin just need to change the package name as this is a PR from my master.

bradmartin commented 4 years ago

Tried running the build script:

> nativescript-lottie@5.0.0 build.plugin.esm /Users/bradmartin/Desktop/nativescript-lottie
> tsc -skipLibCheck --target es2015 --module esnext --removeComments --outDir build/esm && node ./build.esm.js

internal/modules/cjs/loader.js:796
    throw err;
    ^

Error: Cannot find module '/Users/bradmartin/Desktop/nativescript-lottie/build.esm.js'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:793:17)
    at Function.Module._load (internal/modules/cjs/loader.js:686:27)
    at Function.Module.runMain (internal/modules/cjs/loader.js:1043:10)
    at internal/main/run_main_module.js:17:11 {
  code: 'MODULE_NOT_FOUND',
  requireStack: []

doesn't look like build.esm.js is uploaded.

farfromrefug commented 4 years ago

My bad let me clean this up.

EDIT : changed back the package name too

farfromrefug commented 4 years ago

THe PR is closed. can you add me as a contributor? will fix this