nativescript-community / ui-material-components

Monorepo that contains all of the NativeScript Material Design plugins.
https://nativescript-community.github.io/ui-material-components/
Apache License 2.0
216 stars 80 forks source link

feat(BottomSheet): add vue 3 support #429

Closed vallemar closed 1 year ago

vallemar commented 1 year ago

@farfromrefug this is working for vue 3. I don't know if the approach to install this version like

import { BottomSheetPlugin } from '@nativescript-community/ui-material-bottomsheet/vue-3';

is the most correct. If you think we could do it differently, tell me and I'll change it.

This PR have dependency of https://github.com/nativescript-community/plugin-seed-tools/pull/2

farfromrefug commented 1 year ago

@vallemar looks fine. Just wondering if @nativescript-community/ui-material-bottomsheet/vue3 wouldnt be better than @nativescript-community/ui-material-bottomsheet/vue-3 . The - kind of bugs me. If you prefer vue-3 i ll merge it like this

vallemar commented 1 year ago

@farfromrefug no no, in fact I started doing it withvue3 but I changed it because I thought I would prefer vue-3. I will change it and update it.