nativescript-rtl / ui

Add right-to-left support to the NativeScript framework
MIT License
24 stars 3 forks source link

integrate into the core #19

Open farfromrefug opened 3 years ago

farfromrefug commented 3 years ago

First I really like what you did. I think it would be great to have that feature in N a note on the implementation. you don't need to override all layouts. you could.simply create a mixin and apply it to LayoutBase. that way when read we could simply copy paste the code in N LayoutBase class. this is what I did iny material components . that way you could bring RTL to any layout sublcassing LayoutBase.

xlmnxp commented 3 years ago

First I really like what you did. I think it would be great to have that feature in N a note on the implementation. you don't need to override all layouts. you could.simply create a mixin and apply it to LayoutBase. that way when read we could simply copy paste the code in N LayoutBase class. this is what I did iny material components . that way you could bring RTL to any layout sublcassing LayoutBase.

that great idea, I want to merge it to NS maybe your idea will help a lot