I'm not too fond of PR's doing a lot of things, but I think it's a bit hard to extract individual changes without making them depend on each other.. so bear 🐻 with me:
Added a README with some basic info on how to get started running this repo locally.
Added margins to make the screenshots look nicer (that's what I started this PR for in the first place).
Replaced the ListView on the homescreen by a WrapLayout with buttons so the content won't render outside the viewport when a add a few more items (because Appium would not be able to click those items, unless we'd add some error-prone scrolling logic).
Added an ActionBar to the homepage so going back and forth is more pleasant to the eyes on iOS (there was a 'jump' when going back and forth because of the height difference between the master and detail pages).
Set the Switch's checked property to true to make the screenshot look nicer.
Changed the 'dialogs' examples' require statements from ('ui/dialogs') to ('tns-core-modules/ui/dialogs') as prefixing the TNS modules this way is recommended.
Because the mounted event in the 'dialogs' examples is triggered too soon (for the page transition to complete) the navigation would break after one of those routes were triggered. Adding a setTimeout fixes it.
With the latest dependencies findElementByText didn't work on Android, so I've added findElementByXPath (which doesn't work on iOS).
While navigating back twice will close a dialog and then navigate back works on Android, it doesn't work on iOS. On iOS we need to explicitly press the cancel/ok button of the dialog.
rigor789
commented
6 years ago
I'm not too fond of PR's doing a lot of things, but I think it's a bit hard to extract individual changes without making them depend on each other.. so bear 🐻 with me:
ListViewon the homescreen by aWrapLayoutwith buttons so the content won't render outside the viewport when a add a few more items (because Appium would not be able to click those items, unless we'd add some error-prone scrolling logic).ActionBarto the homepage so going back and forth is more pleasant to the eyes on iOS (there was a 'jump' when going back and forth because of the height difference between the master and detail pages).Switch'scheckedproperty totrueto make the screenshot look nicer.requirestatements from('ui/dialogs')to('tns-core-modules/ui/dialogs')as prefixing the TNS modules this way is recommended.mountedevent in the 'dialogs' examples is triggered too soon (for the page transition to complete) the navigation would break after one of those routes were triggered. Adding asetTimeoutfixes it.findElementByTextdidn't work on Android, so I've addedfindElementByXPath(which doesn't work on iOS).