nativeshell / examples

Other
63 stars 7 forks source link

Window Management child windows are wrong size until text changes #8

Closed nyanpasu64 closed 3 years ago

nyanpasu64 commented 3 years ago

In the Window Management tab, "Show Modal Dialog" and "Show Other Window" spawns windows which are the wrong size:

Screenshot_20210617_130312

Screenshot_20210617_131520

If I click "Show Modal Dialog", then tabbing over to "Show more options..." (which is invisible) and pressing Space or Enter fixes the dialog (and it remains the correct size after I "Hide more options..."):

Screenshot_20210617_131656

If I click "Show Other Window", then clicking "Call Method" fixes the window size:

Screenshot_20210617_131530

Versions:

I'm running this repo, latest main d385acefcc2405ddb863f79e3ccdb4479891008c, on Linux.

Flutter 2.3.0-17.0.pre.386 • channel master • https://github.com/flutter/flutter.git Framework • revision c6cd8a60c3 (17 hours ago) • 2021-06-16 22:14:02 -0400 Engine • revision df3aa14215 Tools • Dart 2.14.0 (build 2.14.0-216.0.dev)

System info:

Operating System: Arch Linux KDE Plasma Version: 5.22.1 KDE Frameworks Version: 5.83.0 Qt Version: 5.15.2 Kernel Version: 5.12.10-zen1-1-zen (64-bit) Graphics Platform: X11 Processors: 12 × AMD Ryzen 5 5600X 6-Core Processor Memory: 15.6 GiB of RAM Graphics Processor: NVIDIA GeForce GT 730/PCIe/SSE2

knopp commented 3 years ago

This looks like a possible Gtk+ issue. I haven't tried this with KDE/Plasma yet to be honest.

knopp commented 3 years ago

This is actually related to #7.

nyanpasu64 commented 3 years ago

I think #7 is resolved but this issue persists.

knopp commented 3 years ago

This issue should be fixed by this commit. However neither rust crate or dart package has been updated yet.

nyanpasu64 commented 3 years ago

Thank you for working on this project! Do you want me to report more bugs and crashes in the example app, nativeshell, and/or Flutter itself, or is this too much work?

knopp commented 3 years ago

Please keep reporting them :)

nyanpasu64 commented 3 years ago

I tried testing the latest nativeshell git, but the dialog sizing issue is not fixed.

I edited Cargo.toml:

nativeshell = { git = "https://github.com/nativeshell/nativeshell.git", branch = "main" }

Cargo.lock points to:

source = "git+https://github.com/nativeshell/nativeshell.git?branch=main#8bfab24602be2eb1bf55a094a8bd15954fa90d8f"

The commit, https://github.com/nativeshell/nativeshell/commit/8bfab24602be2eb1bf55a094a8bd15954fa90d8f, is a descendant of your bugfix in https://github.com/nativeshell/nativeshell/commit/ef4f640af55785b8992ac0ace64001690c6ea5c0, but the problem persists.

Also the bug happens on both KDE and GNOME Xorg.

knopp commented 3 years ago

The fix is in the nativeshell dart package. I've just published updated package.

nyanpasu64 commented 3 years ago

It seems fixed, thanks!