search

nativesintech / indigemoji

Indigenous emoji for your (Slack | Discord | Discourse)
MIT License
23 stars 2 forks source link

Added in medicine wheel href to json and formatted file #11

Closed RussWilkie closed 2 years ago

RussWilkie commented 2 years ago

PR for the following issue:

https://github.com/nativesintech/indigemoji/issues/5

RussWilkie commented 2 years ago

I also noticed when I run all the command breaks at scrapers/wiki-flags/index.js at line 22( let file_path = $img_a.attr('href').split('/wiki/File:')[1]). This looks to be happening if $img_a.attr('href') is undefined. I put in a conditional to simply do an empty return if it does find the attribute as undefined.

If preferred, I can remove this commit and just have this PR contain the added Medicine Wheel change.

arecvlohe commented 2 years ago

If preferred, I can remove this commit and just have this PR contain the added Medicine Wheel change.

I think if it helps improve the code then it's a welcome change.