natlv / pe

0 stars 0 forks source link

Use of the term "vehicles" in UG and DG is ambiguous #12

Open natlv opened 4 days ago

natlv commented 4 days ago

The term "vehicle" is used often but could well include motorcycles and lorries, which will have a different licence plate system. As such, its usage may be confusing to readers.

nus-se-script commented 18 hours ago

Team's Response

Thank you for your feedback. However, this issue does not constitute a bug. Below is the rationale for rejecting this report:

Reason for Rejection

Different vehicles, such as Cars, Motorcycles, Lorries, Buses, etc., do have different VRN prefixes. However, vehicle registration numbers in Singapore administered and issued by the Land Transport Authority are all accepted by MATER, as MATER checksum validation follows LTA's checksum algorithm as linked in the UG.

MATER's usage is not limited to a single vehicle type, workshops that choose to work with multiple vehicle types may do so without any issues. Furthermore, a severity of High for a non-issue (no major problem as MATER still accepts different license plate systems) is dramatic.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Thank you for your response.

However, contrary to your reason given, workshops that work with multiple vehicle types will indeed face an issue because of your VRN validation system.

Take private buses for example. The format used for their license plate is PX####X, where X is a letter and # is a number. All of these plates will be rejected in your system.

Screenshot 2024-11-19 at 12.03.15 PM.png

A similar issue would be applicable for any goods vehicles.

Screenshot 2024-11-19 at 12.04.59 PM.png

It is also still common to see motorcycles bearing the license plate format FX####X or lorries bearing the license plate format GX####X, which was the original reason I came up with this bug.

As such, I will be contesting this response, as I believe it should be accepted as a documentation error due to the inconvenience it could indeed cause to users in your wider target audience.

However, I will accept your chosen severity of Low given that you did mention MATER is designed for car workshops, even though this could have been made even clearer by specifying this at the beginning the UG rather than the middle.

For additional reference:

Beginning of UG (very vague, definitely a major issue if no further narrowing of target audience)

Screenshot 2024-11-19 at 1.18.18 PM.png

User Base discussed later in the UG (more specific, justifies severity of Low since the group specified here may not face the issue mentioned, however a general vehicle workshop owner may already have experienced the shortcomings of the app)

Screenshot 2024-11-19 at 1.18.33 PM.png


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.High`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]