search

nats-io / homebrew-nats-tools

Repository hosting homebrew taps for nats-io tools
Apache License 2.0
5 stars 5 forks source link

Added missing macos intel hardward check in nsc formula #10

Closed neerajyadav closed 2 years ago

neerajyadav commented 2 years ago

closes #9 macos intel hardware check was removed from nsc formula due to which brew tap command was not working on intel chip macs. Fixed the issue.

neerajyadav commented 2 years ago

@aricart can you please have a look at it?

philpennock commented 2 years ago

Did that SHA256 checksum actually work for you?

For nsc-darwin-amd64.zip I see d68a0566ce11d70db65f19b288f97b43b69b6c54eccd9ba408181eb561197583 both in a downloaded file and in SHA256SUMS-nsc.txt, so I don't think this can be merged as-is.

Going forward, we need to fix the goreleaser brews configuration to handle this, so we don't repeat this.

philpennock commented 2 years ago

Indeed, 606ff0bc98b3249091036fd6ea62c10abae18e03a847336e1e04412881ef1be7 is from nsc version 2.6.1, so this PR was a good pointer but not the right final solution. In the meantime, #11 has fixed this more completely, as a manual backwards apply after fixing nats-io/nsc#489