Closed matthiashanel closed 4 years ago
Thanks will take a look.
I see it is requesting deliverAll and deliverLast which it properly errors on, you can only chose one. But it must not clean it self up properly or something..
On jsm side I will be more careful about these combos, will check tomorrow
Might also be the advisory being generated.. Will check it out.
Yes I realized that this is what is going on inside the server. I do not explicitly set both...
In general can we improve the errors returned?
Currently we return a generic error, can we add details? (
jsm uses a starting template and merged your options with that template. I wasn’t careful to avoid impossible combos there
Regardless server needs to not do what it does. I have worked on better errors but people don’t seem to like it (myself included)
I will fix server issue.
ok fixed in jetstream branch.
That seems to have done it.
@ripienaar , I created a separate issue for the jsm library. Personally I'd fix this by making it impossible through changing the format altogether. Similar for consumer options.
Server consumes 100% cpu and becomes un responsive. (below are two different dumps of go routines) Version used trunk. I was investigating an issue when creating a consumer using StartWithLastReceived. I will continue investigating my original issue and update this one if it turns out they are related. Filing the issue now so it's not lost...
I am using jsm to create a stream and a consumer. Consumer creating fails for a reason that I'm currently investigating But basically it fails whenever I use
The code involved works fine when using jsm.DeliverAllAvailable instead of jsm.StartWithLastReceived. As soon as I use jsm.StartWithLastReceived() it fails with the above issue.
When I then played around creating the consumer manually using nats the tool times out.
Cpu goes up to 100%
ctrl c seems to not work anymore either. Below are two traces: first one with ctrl+\ to dump the stacks The second one I do ctrl+c before ctrl+\, there the stack seems a little more interesting. (waiting for a lock?)
---------- Second try with ctrl c before dumping go routines