search

nats-io / jsm.go

JetStream Management Library for Golang
Apache License 2.0
151 stars 26 forks source link

[Feature Request] Can we add the monitor-related config in context? #511

Closed yeqown closed 8 months ago

yeqown commented 8 months ago

Background: https://github.com/nats-io/nats-top/pull/98#issuecomment-1870678870

I'm adding context support in nats-top, natscontext is helpful to interact with multi nats clusters, but it doesn't carry the monitor-related config, such as the port (default 8222)

yeqown commented 8 months ago

If necessary, I'd love to make a PR

ripienaar commented 8 months ago

As per comments in nats top pr no I wouldn’t add it here

nats top needs to start using the nats network for access to monitor data. It’s the reason it isn’t available as “nats too” - it would be highly desirable to add it to the nats command.

So I am not adding things here to prolong its independence.

cc @jnmoyne

yeqown commented 8 months ago

I see. So is there any plan to support nats top or nats server top command yet?

ripienaar commented 8 months ago

Need to test a few more things but should be in next release https://github.com/nats-io/natscli/pull/942