search

nats-io / jsm.go

JetStream Management Library for Golang
Apache License 2.0
151 stars 26 forks source link

[ADD] DeliverBodies to disable headersOnly #546

Closed ramonberrutti closed 2 months ago

ramonberrutti commented 2 months ago

Add DeliverBodies, which allows a consumer to be updated with headersOnly: false

This change will also be helpful for Nack: https://github.com/nats-io/nack/blob/main/controllers/jetstream/consumer.go#L408-L410

ripienaar commented 2 months ago

Seems you wanted to push a commit that moves to DeliverBodies() but github pr diff still shows the old names

If not already done in the new code please update the comment on HeadersOnly indicating that the new function inverts it

ramonberrutti commented 2 months ago

Seems you wanted to push a commit that moves to DeliverBodies() but github pr diff still shows the old names

If not already done in the new code please update the comment on HeadersOnly indicating that the new function inverts it

Thank you. I edited the commit message and did not push the changes.

ripienaar commented 2 months ago

Thank you!