search

nats-io / k8s

NATS on Kubernetes with Helm Charts
Apache License 2.0
456 stars 305 forks source link

NACK: Add additionalArgs value to provide to the controller #666

Closed dmitryabramov-f3 closed 1 year ago

dmitryabramov-f3 commented 1 year ago

Allow to specify a dedicated namespace for nack to watch instead of the same namespace it's deployed to. The use case for us is that we have several nats servers and corresponding nacks running in the same cluster that should be looking in specific namespaces for CRD resources.

UPD: as suggested by @caleblloyd - introducing generic additionalArgs value to pass to the controller process. In our case it will be:

additionalArgs:
  - "--namespace=<dedicated namespace>"
caleblloyd commented 1 year ago

I think it might be better to call it additionalArgs: [] in values.yaml and pass all of the additional args specified in that array to the controller process

caleblloyd commented 1 year ago

Please allow maintainers to edit your PR branch, there is a change I need to push to this

caleblloyd commented 1 year ago

Please allow maintainers to edit your PR branch, there is a change I need to push to this

Actually it may already be enabled, I was trying to use GH Codespaces because editing forks is a lot of steps locally but GH Codespaces may be blocking my push :man_facepalming: