nats-io / k8s

NATS on Kubernetes with Helm Charts
Apache License 2.0
455 stars 305 forks source link

fix(surveryor): make configmap fully agnostic #693

Closed Kriys94 closed 1 year ago

Kriys94 commented 1 year ago

This PR:

With the values:

  jetstream:
    enabled: true
    accounts:
    - name: basic
      username: username
      password: password

This will output

# Source: surveyor/templates/configmap.yaml
apiVersion: v1
kind: ConfigMap
metadata:
  name: RELEASE-NAME-surveyor-accounts
  labels:
    helm.sh/chart: surveyor-0.16.0
    app.kubernetes.io/name: surveyor
    app.kubernetes.io/instance: RELEASE-NAME
    app.kubernetes.io/version: "0.5.0"
    app.kubernetes.io/managed-by: Helm
data:
  basic.json: |
    {"name":"basic","password":"password","username":"username"}

For context, I cannot use surveyor right now for the 2 fixes

Kriys94 commented 1 year ago

Done. I changed it to 0.5.1 and I need another approval.