helm charts v1.0.0 nukes image pull secrets

[treksler]

looks to me like since v1.0.0 image pull secrets are gone from the nats chart, which obviously makes the chart useless if you're using a private registry and authenticating with pull secrets https://github.com/nats-io/k8s/pull/770

[treksler]

Ristos-M1-MacBook-Pro:nats rtreksler$ git checkout main
Already on 'main'
Your branch is up to date with 'origin/main'.
Ristos-M1-MacBook-Pro:nats rtreksler$ ack -ri imagepullsecrets .
Ristos-M1-MacBook-Pro:nats rtreksler$ git checkout nats-0.19.17
HEAD is now at e99e6a9 Bump nats from 2.9.19-alpine to 2.9.20-alpine in /helm/charts/nats (#764)
Ristos-M1-MacBook-Pro:nats rtreksler$ ack -ri imagepullsecrets .
README.md
888:imagePullSecrets:
896:  imagePullSecrets:

templates/nats-box.yaml
65:      {{- with .Values.imagePullSecrets }}
66:      imagePullSecrets:

templates/statefulset.yaml
52:      {{- with .Values.imagePullSecrets }}
53:      imagePullSecrets:

values.yaml
352:# An array of imagePullSecrets, and they have to be created manually in the same namespace
354:imagePullSecrets: []
557:  # An array of imagePullSecrets, and they have to be created manually in the same namespace
559:  imagePullSecrets: []

0.19.17 appears to be last usable version

[caleblloyd]

podTemplate:
  merge:
    spec:
      imagePullSecrets:
      - name: regcred

[caleblloyd]

For natsBox it should be

natsBox.deployment.merge.spec.imagePullSecrets

Since this appears in a couple places we could look at adding it to global.image

[caleblloyd]

790

[treksler]

ok, that's neat for merging arbitrary stuff.

I agree that this is a common enough a use case that it should be in global.image. Thanks for the reply

[mm-dibuco]

you should use the following for NATS-Box: natsBox.podTemplate.merge.spec.imagePullSecrets

(change deployment with podTemplate) This works for me.