nats-io / k8s

NATS on Kubernetes with Helm Charts
Apache License 2.0
446 stars 302 forks source link

volumeClaimTemplates can't sync with argocd #847

Closed MikeDevresse closed 8 months ago

MikeDevresse commented 8 months ago

What version were you using?

2.10.7

What environment was the server running in?

Docker image on kubernetes (eks)

Is this defect reproducible?

When installing the helm chart in cluster mod with fileStore, sometimes the app is not syncing in argocd because small diff with how the volumeClaimTemplate is defined.

image

Given the capability you are leveraging, describe your expectation?

This doesn't change anything except for the fact that the argocd app is always out of sync.

Given the expectation, what is the defect you are observing?

ArgoCD app is out of sync

caleblloyd commented 8 months ago

Are you using ServerSideApply=true? Looks like this is related to https://github.com/argoproj/argo-cd/issues/11143 which is still open

Examples in the Kubernetes Docs do not explicitly set an apiVersion or kind on volumeClaimTemplates, so I don't think we should do it here. Probably better to workaround it in ArgoCD by ignoring that difference, there are some suggestions in the ArgoCD Issue thread for how to do that

MikeDevresse commented 8 months ago

Yes that fixed it, If you think it's better to not set it then we can close the issue and PR