nats-io / k8s

NATS on Kubernetes with Helm Charts
Apache License 2.0
444 stars 300 forks source link

Don't enable WebSocket compression by default #912

Closed neilalexander closed 2 months ago

neilalexander commented 2 months ago

Currently there are some problems where the flate writer might take up more allocations than expected when there are lots of WebSocket clients.

Signed-off-by: Neil Twigg neil@nats.io

caleblloyd commented 2 months ago

My original thought was that enabling compression by default was good for most common use cases, since Cloud Provider bandwidth is so expensive.

But if the desire is to optimize for high performance scenarios on fast network connections, I digress.

The tests that assert compression is on in the chart’s test sub directory need to be changed from true to false