search

nats-io / nack

NATS Controllers for Kubernetes (NACK)
Apache License 2.0
155 stars 61 forks source link

Add support for UserCredentials for consumer #132

Closed eugenestarchenko closed 1 year ago

eugenestarchenko commented 1 year ago

Sadly NACK does not work for jetstream consumers the way we use it :pensive: the piece of code that looks up the credentials from the account object is missing for the consumer https://github.com/nats-io/nack/blob/6c54a4ea35b36117c490ed2afc5b86b96e93085c/controllers/jetstream/consumer.go#L95 here is the equivalent piece for the stream object (which works fine) https://github.com/nats-io/nack/blob/6c54a4ea35b36117c490ed2afc5b86b96e93085c/controllers/jetstream/stream.go#L110-L132

https://github.com/nats-io/nack/blob/main/controllers/jetstream/consumer.go#LL95C29-L95C44

Do you have a possible ETA for this case? Thank you!

AMarti96 commented 1 year ago

This should be fixed in https://github.com/nats-io/nack/pull/128