search

nats-io / nats-architecture-and-design

Architecture and Design Docs
Apache License 2.0
187 stars 20 forks source link

Remove Fetch Batch size limit #109

Closed scottf closed 1 year ago

scottf commented 2 years ago

Overview

The original ADR specified that fetch batch limit should be enforced by the client at 256. This has changed and the ADR has been updated. Clients that enforce a limit should be changed to remove

The behavior is documented in ADR-13 which has been recently updated for this change. https://github.com/nats-io/nats-architecture-and-design/pull/108

Clients and Tools

Other Tasks

Client authors please update with your progress. If you open issues in your own repositories as a result of this request, please link them to this one by pasting the issue URL in a comment or main issue description.

aricart commented 2 years ago

The javascript clients didn't enforce any limit or lack of, as ultimately the nats-server should be the one to accept or reject protecting itself.

scottf commented 2 years ago

@aricart Originally in the ADR it said to limit the batch fetch size to 256. This requirement was removed, so the issue is for those clients that implemented the limit to remove them. If your client does not limit the fetch size, you can mark this issue complete.