search

nats-io / nats-architecture-and-design

Architecture and Design Docs
Apache License 2.0
177 stars 20 forks source link

Failed Authentication Opt-out #170

Open aricart opened 1 year ago

aricart commented 1 year ago

Overview

Traditionally clients have aborted reconnect reattempts after 2 consecutive authentication errors. https://github.com/nats-io/nats.go/pull/499

In some setups this behavior creates a different problem because a configuration mistake on the server will stop thousands of clients.

Provide a connect option ignoreAuthErrorAbort that prevents the 2 consecutive errors from aborting the reconnect attempts. See https://github.com/nats-io/nats.deno/commit/cf2b33cb8a936841e536adbd453bb4755aa6fdb5 - javascript client changes to fix this.

Clients and Tools

Other Tasks

Client authors please update with your progress. If you open issues in your own repositories as a result of this request, please link them to this one by pasting the issue URL in a comment or main issue description.

bruth commented 1 year ago

@aricart No urgency, but is this and #171 extending an existing ADR or does a new one need to be created?

aricart commented 1 year ago

@aricart No urgency, but is this and #171 extending an existing ADR or does a new one need to be created?

@bruth there's no ADR - this is just a connect option to prevent the default client behaviour.

bruth commented 1 year ago

Ok thanks, that is what I assumed. I am in the process of evolving some PR templates to help differentiate the kinds of issues that are created in this repo.