nats-io / nats-architecture-and-design

Architecture and Design Docs
Apache License 2.0
177 stars 20 forks source link

Consumer Configuration Max Waiting #24

Closed scottf closed 1 year ago

scottf commented 2 years ago

Overview

Consumer Max [Pull] Waiting Messages is a new field in consumer_configuration.

    "max_waiting": {
      "description": "The number of pulls that can be outstanding on a pull consumer, pulls received after this is reached are ignored",
      "minimum": 0,
      "default": 512,
      "$comment": "integer with a dynamic bit size depending on the platform the cluster runs on, can be up to 64bit",
      "type": "integer",
      "maximum": 9223372036854775807
    },

Clients and Tools

Other Tasks

Client authors please update with your progress. If you open issues in your own repositories as a result of this request, please link them to this one by pasting the issue URL in a comment or main issue description.

aricart commented 2 years ago

@scottf can you fix the reference to ADR-X, also are there any client expected changes other than possibly setting the value.

scottf commented 2 years ago

fixed. No adr, just a field to add

caspervonb commented 2 years ago

Seems like this has already landed nats.rs and can be marked as complete: https://github.com/nats-io/nats.rs/blob/main/src/jetstream_types.rs#L132

bruth commented 1 year ago

Appears Python supports this as early as https://github.com/nats-io/nats.py/pull/216 /cc @wallyqs

bruth commented 1 year ago

Present in docs and no ADR, so closing.