Push Consumer active information and queue group binding

ripienaar commented 2 years ago

Overview

A number of Push related changes were made:

A new ConsumerInfo boolean push_bound indicates if any subscriber is currently active on a Push Consumer. Additionally a new property deliver_group instructs the server to only deliver messages to subscriptions matching a queue group of deliver_group.

On the Sequence Pairs for ack floor and delivered is a new timestamp that shows when last message was ACKed (not NAK or Term) and when last a message was delivered

Server PR https://github.com/nats-io/nats-server/pull/2438 See ADR: https://github.com/nats-io/nats-architecture-and-design/blob/main/adr/ADR-15.md section: https://github.com/nats-io/nats-architecture-and-design/blob/main/adr/ADR-15.md#push-consumer-active-information-and-queue-group-binding

Clients and Tools

[x] Schemas @ripienaar
[x] CLI @ripienaar
[x] Terraform @ripienaar
[x] Go @wallyqs
[x] Java @scottf
[x] JavaScript
[x] .Net @ColinSullivan1 @scottf
[x] C @kozlovic
[x] Python @wallyqs
[x] Rust @Jarema

Other Tasks

[x] docs.nats.io updated
[x] Update the JS Context Subscribe behavior ADR if not in there already
[x] Update client features spreadsheet

Client authors please update with your progress. If you open issues in your own repositories as a result of this request, please link them to this one by pasting the issue URL in a comment or main issue description.

ripienaar commented 2 years ago

HOLD on this one, we're changing how this works.

ripienaar commented 2 years ago

HOLD on this one, we're changing how this works.

This is ready to implement, the approach has been redesigned, description, schemas etc updated.

aricart commented 2 years ago

@ripienaar can you elaborate on what the behavior should be from the client's perspective on deliver_group. I would assume that this would be:

set on the consumer creation if a group was specified
In cases where the consumer already exists, if the consumer doesn't specify the queue group or the queue group name is different the client should reject

ripienaar commented 2 years ago

@aricart I think @kozlovic is probably most on top of what is expected from clients on this one