search

nats-io / nats-box

A container with NATS utilities
Apache License 2.0
105 stars 32 forks source link

change extrypoint to cmd #35

Closed steevehook closed 1 year ago

steevehook commented 1 year ago

This PR leaves everything exactly the same except it allows for command override

wallyqs commented 1 year ago

I think this might be fine to include but need to double check that it may not break other areas like the Helm charts, there is also docker run --entrypoint that might help in the mean time.

steevehook commented 1 year ago

It won't break anything it will acts as ENTRYPOINT except people now can overwrite the command without specifying entrypoint. This is especially useful when execing on already running containers

caleblloyd commented 1 year ago

Fixed in #47 and will be in next release