Closed variadico closed 3 years ago
I was thinking of doing a follow up PR to include documentation, since his PR is a little big already.
Merging #49 (6cbfbef) into main (acd46a8) will decrease coverage by
0.40%
. The diff coverage is72.29%
.
@@ Coverage Diff @@
## main #49 +/- ##
==========================================
- Coverage 75.70% 75.30% -0.41%
==========================================
Files 16 18 +2
Lines 1099 1247 +148
==========================================
+ Hits 832 939 +107
- Misses 195 215 +20
- Partials 72 93 +21
Impacted Files | Coverage Δ | |
---|---|---|
server/conf/conf.go | 78.94% <ø> (ø) |
|
server/core/server.go | 57.36% <50.00%> (-0.50%) |
:arrow_down: |
server/core/kafka2jetstream.go | 70.73% <70.73%> (ø) |
|
server/core/connector.go | 71.48% <74.00%> (+0.61%) |
:arrow_up: |
server/core/nats.go | 58.88% <75.00%> (+3.48%) |
:arrow_up: |
server/core/jetstream2kafka.go | 79.31% <79.31%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update acd46a8...6cbfbef. Read the comment docs.
LGTM. Thanks! A future PR could create streams and consumers dynamically, but this is good for the time being.
This adds JetStream support to nats-kafka. It's based off the NATS and STAN implementations.
Closes #41
Testing
You can run the tests locally like this. (Automatically sets up and tears down Docker containers and runs Go tests.)
In addition, this is how I tested manually.
Here's the config file.