Closed drnushooz closed 2 years ago
Merging #61 (48764fe) into main (9e878e1) will decrease coverage by
0.73%
. The diff coverage is39.28%
.
@@ Coverage Diff @@
## main #61 +/- ##
==========================================
- Coverage 67.93% 67.19% -0.74%
==========================================
Files 27 27
Lines 1759 1759
==========================================
- Hits 1195 1182 -13
- Misses 437 448 +11
- Partials 127 129 +2
Impacted Files | Coverage Δ | |
---|---|---|
server/kafka/partitioner.go | 26.92% <0.00%> (-14.26%) |
:arrow_down: |
server/kafka/packer_utils.go | 60.00% <60.00%> (-40.00%) |
:arrow_down: |
server/kafka/pb_schema_manager.go | 69.04% <100.00%> (ø) |
|
server/kafka/pb_serializer.go | 64.86% <100.00%> (-0.93%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 9e878e1...48764fe. Read the comment docs.
I can do a bug fix release, 1.2.1.
I can do a bug fix release, 1.2.1.
That sounds great!
This PR fixes the
buildMessageIndexes
function where the indexBuf would not get the result of the loop variable. This also improves thepacker_utils
to use big endian instead of small to provide consistency throughout the code.