search

nats-io / nats-operator

NATS Operator
https://nats-io.github.io/k8s/
Apache License 2.0
573 stars 111 forks source link

pkg: add gatewayport and leafnodeport to service #316

Closed squat closed 3 years ago

squat commented 3 years ago

This commit ensures that the gateway and leafnode ports are added to the management service created for a cluster.

Signed-off-by: Lucas Servén Marín lserven@gmail.com

Plz let me know if these ports should also be added to the client service. The ports were added to the headless service to match the Helm charts and raw YAML files, e.g. https://github.com/nats-io/k8s/blob/master/helm/charts/nats/templates/service.yaml#L35-L38 Similarly, the port names are pluralized, i.e. leafnodes and gateways to match.

wallyqs commented 3 years ago

I think just adding to the management service is fine, thanks for the contribution!

squat commented 3 years ago

@wallyqs do we need to do anything special to get the CI to finish?

wallyqs commented 3 years ago

Not sure what changed in travis, the build itself seems fine: https://travis-ci.com/github/nats-io/nats-operator/builds/223332812