[TEST only] A test for memory leak when creating/deleting consumers

nats-io / nats-server

High-Performance server for NATS.io, the cloud and edge native messaging system.

https://nats.io

Apache License 2.0

15.1k stars 1.36k forks source link

[TEST only] A test for memory leak when creating/deleting consumers #5603

Closed levb closed 2 days ago

levb commented 3 days ago

Verifies the fix in https://github.com/nats-io/nats-server/pull/5600

When ran locally, it was using ~180MB extra for the test before, and under 40Mb after.

levb commented 3 days ago

@derekcollison @neilalexander https://app.travis-ci.com/github/nats-io/nats-server/jobs/623464530 is causing a race in raft, do you mind taking a look?

This line here is not being executed under a lock. https://github.com/nats-io/nats-server/pull/5600/files#diff-0a3d4e9b87bb3880bdb735fa489ef618b571de3370dae31d8f509b26e2fb852eR1737 when called from n.runAsLeader()

levb commented 2 days ago

Apologies, but either I messed something up when merging/rebasing or GitHub is having issues, I will close this PR and submit a new one since there's little history here anyway.