Hello.
I saw that readCacheFlag is using Value Receiver on in server/client.go.
I think there is no reason to use Value Receiver instead of Pointer Receiver. And also
If there is any reason to use Value Receiver, please let me know why! It would be helpful to understand your code :)
Use case
I think using pointer receiver is better in this case.
neilalexander
commented
1 month ago
Proposed change
Hello. I saw that
readCacheFlagis using Value Receiver on in server/client.go. I think there is no reason to use Value Receiver instead of Pointer Receiver. And also If there is any reason to use Value Receiver, please let me know why! It would be helpful to understand your code :)Use case
I think using pointer receiver is better in this case.
Contribution
Yes. I would like to contribute to this issue.