search

nats-io / nats-server

High-Performance server for NATS.io, the cloud and edge native messaging system.
https://nats.io
Apache License 2.0
16.02k stars 1.41k forks source link

[FIXED] Handle recreating file-based stream to be memory on meta recovery #6069

Closed MauriceVanVeen closed 3 weeks ago

MauriceVanVeen commented 3 weeks ago

For the following scenario:

  1. create file-based R3 stream
  2. delete stream
  3. create memory-based R3 stream
  4. add a consumer

The call to js.processStreamAssignment(sa) even while we're recovering would mean that on meta recovery we'd first create the file-based stream, then create the memory-based stream and fail to do so since we can't change storage types. Which then leaves us stranded with 2 nodes having a memory-based stream, and that one node with a file-based stream.

This change proposes to have the stream additions be consistent with the other collecting of state into ru *recoveryUpdates before applying, and waiting until recovery is finished to do so.

Signed-off-by: Maurice van Veen github@mauricevanveen.com Co-authored-by: Neil Twigg neil@nats.io