search

nats-io / nats-server

High-Performance server for NATS.io, the cloud and edge native messaging system.
https://nats.io
Apache License 2.0
16k stars 1.41k forks source link

Improve unpinning #6078

Closed Jarema closed 2 weeks ago

Jarema commented 2 weeks ago

Changes introduced:

Do not set default pinned TTL if it's not a pinned client consumer

In one case, we were not checking if given consumer config is a pinned one when setting pinned TTL. That caused the TTL to be always set, which in turn incremented API Level even if Priority Groups were not used.

Rename advisories

Advisories were following ADR, but ADR names were fixed. This follows up the ADR names fix.

Improve unpinning

It was possible that the same client was picked after unpin call. This commit makes sure that different waiting request will be picked.

Signed-off-by: Tomasz Pietrek tomasz@nats.io

Jarema commented 2 weeks ago

cc @jnmoyne

jnmoyne commented 2 weeks ago

LGTM works perfect now! 👌

derekcollison commented 2 weeks ago

Let me know if I should review. Pull draft status too.