search

nats-io / nats-server

High-Performance server for NATS.io, the cloud and edge native messaging system.
https://nats.io
Apache License 2.0
16.02k stars 1.41k forks source link

[FIXED] check of the backoff and max delivery configs #6154

Closed Luisgustavom1 closed 4 days ago

Luisgustavom1 commented 4 days ago

Match the check of the backoff and maxDeliver configs with the official documentation -> https://docs.nats.io/nats-concepts/jetstream/consumers#:~:text=The%20sequence%20length,MaxDelivery

Documentation, tell that Backoff config must be less than or equal to MaxDelivery. But we were checking the opposite

Signed-off-by: Luisao luisgustavomacedo13@gmail.com

neilalexander commented 4 days ago

Is [WIP] because you are planning future changes to this PR?

Luisgustavom1 commented 4 days ago

Is [WIP] because you are planning future changes to this PR?

Yes, I'm writing one more test case, now everything is done! tks