search

nats-io / nats-streaming-operator

NATS Streaming Operator
Apache License 2.0
174 stars 44 forks source link

support watching multiple namespaces #14

Closed visheyra closed 5 years ago

visheyra commented 5 years ago

Enable to watch multiple namespace. This is useful to make the example presented in the README to work. The empty string feature to watch all namespaces is presented here. I'm not sure about how to handle the configuration so this is triggered when the MY_POD_NAMESPACE environment variable is unset.

wallyqs commented 5 years ago

Would this work with the current RBAC policy definition or does it have to change as well? https://github.com/nats-io/nats-streaming-operator/blob/master/deploy/default-rbac.yaml

visheyra commented 5 years ago

Yes. The current role is a cluster wide one.

wallyqs commented 5 years ago

Oh I see, so if namespace is not set (which is by default in the manifests in the repo) then it would watch all clusters, I think that is simple enough. Thanks for the PR!

visheyra commented 5 years ago

Great :) Do you know when you will merge ? This way I would be able to use your image instead of mine :)

visheyra commented 5 years ago

Actually I just noticed taht I made a mistake there are a MY_POD_NAMESPACE and a WATCH_NAMESPACE environment varirable and I don't use the correct one. I will just fix this.